fix: test do not accept multple line string on linux#756
Open
CSUwangj wants to merge 1 commit intoLeetCode-OpenSource:masterfrom
Open
fix: test do not accept multple line string on linux#756CSUwangj wants to merge 1 commit intoLeetCode-OpenSource:masterfrom
CSUwangj wants to merge 1 commit intoLeetCode-OpenSource:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
using shell-quote to deal with multiple line string test case
Why and How:
current plugin accept multiple line string test case, but will lead to run time failure which said something like
it's because arguments pass to leetcode-cli will be something like
123"\n"123, using shell-quote will resolve problem, for the"123"\n"123", it will turned into"'\"123\"\\n\"123\"'".Beware that this solution only apply for Linux platform, I tested in my Ubuntu machine.